----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/#review18113 -----------------------------------------------------------
Why do you want to do this ? Beside that, you are using CMakePushCheckState.cmake, which is part of cmake only since version 2.8.6. trunk still requires cmake 2.6.4, so this is not allowed, use MacroPushrequiredVars.cmake, which we have in kdelibs, instead. - Alexander Neundorf On Aug. 26, 2012, 5:15 p.m., Vadim Zhukov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106174/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2012, 5:15 p.m.) > > > Review request for kdelibs and Michael Pyne. > > > Description > ------- > > This patch does move some run-time checks (mainly for different locking > mechanisms) in KSharedDataCache to build time (CMake). > > > This addresses bug 305023. > http://bugs.kde.org/show_bug.cgi?id=305023 > > > Diffs > ----- > > kdecore/util/config-util.h.cmake 83ccdf7 > kdecore/util/kshareddatacache.cpp 393902e > kdecore/util/kshareddatacache_p.h ec5a7a0 > kdecore/util/ConfigureChecks.cmake fe9f47e > > Diff: http://git.reviewboard.kde.org/r/106174/diff/ > > > Testing > ------- > > On OpenBSD-CURRENT. > > > Thanks, > > Vadim Zhukov > >
