----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18454 -----------------------------------------------------------
Ship it! Thanks, looks good from my point of view! I can't test it at the moment, but you can commit this the the 4.9 branch. There are a couple of weeks to go before 4.9.2 is tagged anyway, and I (and hopefully, more users of the 4.9 branch) will test it until then. dolphin/src/kitemviews/kstandarditemlistwidget.cpp <http://git.reviewboard.kde.org/r/106304/#comment14578> Please remove the '\'. - Frank Reininghaus On Sept. 2, 2012, 10:41 a.m., Todd Jennings wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106304/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2012, 10:41 a.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Description > ------- > > Hide empty additional information lines in icons view mode. Previously they > were "-", which took up a lot of space while providing no additional > information. > > > This addresses bug 304752. > http://bugs.kde.org/show_bug.cgi?id=304752 > > > Diffs > ----- > > dolphin/src/kitemviews/kstandarditemlistwidget.cpp > 7ae7e2efcffc2f68c72a05cdbc3b29abc4c3aff4 > dolphin/src/kitemviews/private/knepomukrolesprovider.cpp > 0ae9b6bd3edf88ea48c40bb491ef9e57148b8062 > > Diff: http://git.reviewboard.kde.org/r/106304/diff/ > > > Testing > ------- > > Tested and it works > > > Thanks, > > Todd Jennings > >
