----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106288/#review18523 -----------------------------------------------------------
Ship it! kparts/listingextension.cpp <http://git.reviewboard.kde.org/r/106288/#comment14687> 2010? You've been waiting for a long time to upload this file :-) - David Faure On Sept. 4, 2012, 7:14 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106288/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 7:14 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > The attached patch adds a new extension, ListingFilterExtension, to KParts. > The main motivation for this patch is the constant breakage of the Konqueror > directory filtering plugin once Konqueror was switched to use Dolphin's part > for filemanagement. Because the dolphin part does not expose the same > features as the implementation in the old Konqueror file management module, I > had to resort to ugly hacks to make this plugin functional. Unfortunately, > that hack no longer works properly because of changes/cleanup done in > Dolphin's code base. Hence, this patch is an attempt to fix this issue once > and for all in a manner that is clean, consistent and useful for any part > that wants to provide filtering functionality. As an additional benefit this > patch will also makes it very easy to add Dolphin's CTRL+I filtering feature > to Konqueror. > > The implementation of this extension in Dolphin can be reviewed at > https://git.reviewboard.kde.org/r/106289/ > > > Diffs > ----- > > kparts/listingextension.cpp PRE-CREATION > includes/CMakeLists.txt 8a956ee > includes/KParts/ListingExtension PRE-CREATION > kparts/CMakeLists.txt 96fa31f > kparts/listingextension.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106288/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
