----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/#review18542 -----------------------------------------------------------
Ship it! Thanks for your understanding and for the new patch, looks good from my point of view! Maybe I'll check at some point if this can be optimised in master by sharing more code between setMimeTypeFilters() and setNameFilter(), but in the stable branch, it's better not to change the existing code too much. You can push to 4.9 after fixing the little issues below. dolphin/src/kitemviews/kfileitemmodel.cpp <http://git.reviewboard.kde.org/r/106289/#comment14697> Please remove the space before '('. dolphin/src/kitemviews/kfileitemmodel.cpp <http://git.reviewboard.kde.org/r/106289/#comment14698> Q_FOREACH -> foreach (consistent with existing Dolphin code). dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp <http://git.reviewboard.kde.org/r/106289/#comment14696> Can be removed. dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp <http://git.reviewboard.kde.org/r/106289/#comment14699> Remove the space before '('. dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp <http://git.reviewboard.kde.org/r/106289/#comment14700> Q_FOREACH(...) -> foreach (...), see above. dolphin/src/views/dolphinview.cpp <http://git.reviewboard.kde.org/r/106289/#comment14701> Remove the space before '('. - Frank Reininghaus On Sept. 4, 2012, 8:01 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106289/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 8:01 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Description > ------- > > The attached patch provides an implementation of KParts' > ListingFilterExtension for Dolphin. The extension allows the Dolphin KPart to > provide directory/file filtering services without requiring direct linking > against Dolphin itself. > > The review for the new KPart listing filter extension > (ListingFilterExtension) can be found at > https://git.reviewboard.kde.org/r/106288/ > > > Diffs > ----- > > dolphin/src/kitemviews/private/kfileitemmodelfilter.h 9bdf1fd > dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp 816d356 > dolphin/src/views/dolphinview.h 10f63c5 > dolphin/src/views/dolphinview.cpp 8050415 > dolphin/src/kitemviews/kfileitemmodel.h d9bebdf > dolphin/src/kitemviews/kfileitemmodel.cpp 6936af4 > dolphin/src/dolphinpart.h e5693b3 > dolphin/src/dolphinpart.cpp fff7dc0 > > Diff: http://git.reviewboard.kde.org/r/106289/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
