> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't help anyway. > > > > Albert Astals Cid wrote: > Because when i sent an email to k-c-d with "Dependency Freeze for 4.10 in > two weeks" asking for depencies like that to be increased noone suggested > changing it > > > Frank Reininghaus wrote: > Thanks Dawit for implementing this! > > About the kdelibs version issue: wouldn't the easiest solution be to > raise the version requirement once master is open again and push the patch to > master then? It won't hurt much if the KIO::SlaveConfig call stays in the > 4.10 branch, right? > > David Faure wrote: > Sounds like a plan.
For the record I did raise my hand in response to your k-c-d post Albert. kde-baseapps in the 4.10 branch REQUIRES a minimum of kdelibs v4.9.80 to work correctly. Otherwise, cookie handling will be completely screwed up if the user launches the cookie configuration dialog. Based on the conversion in the thread you created, I personally did change the KDE_MIN_VERSION flag to 4.9.80, but I did not do anything to the KDE4 flag because I did not know I was supposed to update that too. :( It still would be safe to update KDE4 to the correct version since people won't be able to compile kde-baseapps against any kdelibs version older than v4.9.80 right now, no ? Anyhow, there is no reason to rush this into the 4.10 branch ; so waiting for master to open and the pushing it there indeed sounds like a plan. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107421/#review22391 ----------------------------------------------------------- On Nov. 22, 2012, 5:26 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107421/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2012, 5:26 p.m.) > > > Review request for KDE Base Apps, David Faure and Frank Reininghaus. > > > Description > ------- > > The attached patch ports Dolphin away from using KIO::SlaveConfig::configData > into the newly added KProtocolManager::charsetFor API. KIO::SlaveConfig was > never intended to be a public class and as such it is going to go away in KF5. > > Please note that you need to latest kdelibs from the 4.10 branch in order to > compile this change. > > > Diffs > ----- > > dolphin/src/views/dolphinremoteencoding.cpp 375b3fd > > Diff: http://git.reviewboard.kde.org/r/107421/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
