----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107791/#review24025 -----------------------------------------------------------
I am a bit puzzled by the usage of QSettings for file I/O. My, rather limited, understanding of QSettings in Qt5 context is that is mostly the same as in Qt4 and Qt4's version is AFAIK neither capable of doing hierachical files nor immutable settings nor environment/tool-output dependent values. All of which KConfig can do and which could have been deployed (especially hierachy and immutability). Or maybe I am misunderstanding the purpose of this endeavour, i.e. is this just exploring options and not idended to be ever merged into KF5? kdeui/sonnet/configdialog.h <http://git.reviewboard.kde.org/r/107791/#comment18309> explicit kdeui/sonnet/configdialog.h <http://git.reviewboard.kde.org/r/107791/#comment18310> Is this method necessary anymore? There is only one constructor, right? kdeui/sonnet/configwidget.h <http://git.reviewboard.kde.org/r/107791/#comment18311> explicit kdeui/sonnet/configwidget.cpp <http://git.reviewboard.kde.org/r/107791/#comment18313> Probably also move into constructor? kdeui/widgets/ktextedit.cpp <http://git.reviewboard.kde.org/r/107791/#comment18314> Especially since it seems to hardcode QSettings usage without any option for a KDE application to read from KConfig instead - Kevin Krammer On Dec. 27, 2012, 12:52 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107791/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2012, 12:52 a.m.) > > > Review request for KDE Frameworks, kdelibs and David Faure. > > > Description > ------- > > Ported everything away from KConfig to QSettings. > > I couldn't really find any users of the ::save function, so I think the > source incompatible change would be worth it. Alternatively we could add a > deprecated dummy function that takes in a KConfig object and just ignores it, > and uses QSettings. > > > Diffs > ----- > > kdeui/sonnet/configdialog.h 7c4993b > kdeui/sonnet/configdialog.cpp 625441b > kdeui/sonnet/configwidget.h 023b659 > kdeui/sonnet/configwidget.cpp 549d5af > kdeui/sonnet/highlighter.cpp 6cbb14c > kdeui/sonnet/tests/test_configdialog.cpp 4c4fd21 > kdeui/widgets/ktextedit.h d0c1c4d > kdeui/widgets/ktextedit.cpp 71d2a9f > staging/sonnet/src/core/backgroundchecker.h f0da3a3 > staging/sonnet/src/core/backgroundchecker.cpp dc05b94 > staging/sonnet/src/core/globals.cpp bf4f504 > staging/sonnet/src/core/loader.cpp 887aee5 > staging/sonnet/src/core/settings.cpp 59cb593 > staging/sonnet/src/core/settings_p.h e14bad7 > staging/sonnet/src/core/speller.h 37dd82f > staging/sonnet/src/core/speller.cpp f831f55 > > Diff: http://git.reviewboard.kde.org/r/107791/diff/ > > > Testing > ------- > > it builds. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
