> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > <http://git.reviewboard.kde.org/r/108285/diff/1/?file=106110#file106110line183> > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining if a language is CJK? > > Christoph Feck wrote: > "CJK" is actually naming the languages which use CJK, so the list is > hardcoded by definition. > > Yichao Yu wrote: > I guess the question is not "which languages are CJK" but "which > languages have this problem". > > > Yichao Yu wrote: > Plus, there may be english text even when the current locale is cjk[1], > so I really don't think deciding from the current locale is a good idea. > > Personally, I like what I am having now (larger spacing?). I don't know > what it looks like without word wrap but I think multiple lines is better if > the text is really too long (e.g. "?????????"). I did have a suggestion on > how the word wrap should be done for cjk (see the last few lines in the > description of this bug[2]) i.e. it may be better to keep each lines roughly > the same length. > > For detecting whether word wrapping should be used (and probably what > method should be used in order to have a better appearance e.g. using the > alternative method for CJK I mentioned above), I think it is probably a > better way to detect blank space in the text. It might be a better idea to > increase the threshold (maximum length) if there is not a single space in the > text and use some better method to do word wrapping in such case. This may > work for any language that allow word wrapping (I personally don't know any > language that does not, correct me if I am wrong.....) (including English > (for extremely long words) if you add "-" correctly). > > [1] http://wstaw.org/m/2013/01/09/plasma-desktopr20016.png > [2] https://bugs.kde.org/show_bug.cgi?id=309780 > > > Xuetian Weng wrote: > 1. You are missing zh_HK. > 2. Have you ever consider if a non-translated long-english string appear > in systemsettings (3rd party, maybe), how would your patch affect the > appearance? > > What I would suggest is set a minimum width for delegate (for all > locale), you can use fontMetrics() * constant number, which you can sure the > width is longer than maybe 6-8 CJK character, and you will still have good > looking for non-CJK gui.
I disable wordwrap mode for CJK language because this mode is just a regression for these language. I still clearly remember the day when I upgrade my KDE and open system setting, it looks so ugly :) If it is a regression, than revert it is just a simple way. The old way at least works fine for a long time. It seems most people do not like this simple revert. Here are two possible solution: 1. Set different delegate width: a. If all is non-CJK, no change needed. b. (Not true for most cases) If all items are translated into local CJK language, set width larger c. (Most cases) There are both translated and non-translated items, it is hard to make a decision. For me, I still prefer single line display. But others prefer setting a minimum width, which may make some long English word look bad. Then another solution: 2. Add a configuration option. Let the user choose what they want. - Chao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/#review25038 ----------------------------------------------------------- On Jan. 9, 2013, 4:33 a.m., Chao Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108285/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 4:33 a.m.) > > > Review request for kde-workspace. > > > Description > ------- > > CJK languages do not use space as words seperator. > > And a CJK translation of the text in Systemsettings are very short. A single > line is enough for them. > > > This addresses bug 234407. > http://bugs.kde.org/show_bug.cgi?id=234407 > > > Diffs > ----- > > systemsettings/icons/IconMode.cpp 37cfc4bed42e4d05fc4c01008f8ca2c63b287b5e > > Diff: http://git.reviewboard.kde.org/r/108285/diff/ > > > Testing > ------- > > 1. Apply patch > 2. Systemsetting show ok on CJK > > > Thanks, > > Chao Feng > >
