-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108328/
-----------------------------------------------------------
(Updated Jan. 10, 2013, 6:09 p.m.)
Review request for kde-workspace, Ben Cooksley, Thomas Lübking, Chao Feng, and
Yichao Yu.
Description (updated)
-------
Set minimum width for system settings icon view item depending on font. Since
KFileItemDelegate doesn't provides setMinimumSize, we make a sub-class that can
have a minimumSize. (Maybe should be add to kdelibs in the future?)
This fontHeight * 6 heuristic value works for all languages. CJK character is
usually square (width = height) so this roughly means 6 CJK character, and 12
latin letter (height = width * 2), which will always look good.
To fengchao, I'm sorry if you feel I steal your job.. but I can't stop myself
since I think I can fix it in 10 minutes..
This addresses bug 234407.
http://bugs.kde.org/show_bug.cgi?id=234407
Diffs
-----
systemsettings/icons/CMakeLists.txt 0830dd7
systemsettings/icons/FileItemDelegate.h PRE-CREATION
systemsettings/icons/FileItemDelegate.cpp PRE-CREATION
systemsettings/icons/IconMode.cpp 37cfc4b
Diff: http://git.reviewboard.kde.org/r/108328/diff/
Testing
-------
see screenshot.
Screenshots
-----------
english after change
http://git.reviewboard.kde.org/r/108328/s/1014/
chinese after change
http://git.reviewboard.kde.org/r/108328/s/1015/
chinese before change
http://git.reviewboard.kde.org/r/108328/s/1016/
spanish after change
http://git.reviewboard.kde.org/r/108328/s/1017/
Thanks,
Xuetian Weng
