----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108430/#review25687 -----------------------------------------------------------
Ship it! Looks good to me. - Chusslove Illich On Jan. 15, 2013, 11:29 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108430/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 11:29 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Just one context variable when three elements can have different context set > is really a no go > > > Diffs > ----- > > kdecore/kconfig_compiler/kconfig_compiler.cpp 4203d30 > kdeui/tests/kconfig_compiler/test11.cpp.ref a02b578 > kdeui/tests/kconfig_compiler/test11.kcfg da02706 > kdeui/tests/kconfig_compiler/test11a.cpp.ref 02cfe71 > > Diff: http://git.reviewboard.kde.org/r/108430/diff/ > > > Testing > ------- > > Okteta kcfg now are generated correctly and the stuff that did not get > translated in its settings is now propertly translated. > > > Thanks, > > Albert Astals Cid > >
