----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108541/#review26344 -----------------------------------------------------------
This review has been submitted with commit 9f26a03e17c3f3a3307b161cb59d7d1477c7d268 by Jekyll Wu to branch master. - Commit Hook On Jan. 22, 2013, 11:09 a.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108541/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 11:09 a.m.) > > > Review request for kdelibs and Ben Cooksley. > > > Description > ------- > > Currently kbugreport just can't fill platform information. There are two > reasons: > > 1. kbugreport currently pass the results of uname, while bugs.kde.org expects > a few > predefined values like "Gentoo packages", "Chakra", "Ubuntu packages", etc. > > 2. even if kbugreport passes those expected values, wizard.cgi in its current > form doesn't correctly redirect those info to enter_bugs.cgi, since the > latter expects and understands "sys_os" and "rep_platform" fields, instead of > the "additional_info" field. > > According to this commit[1], the home-made wizard.cgi exists solely for > the sake of compatibility. So I wouldn't expect any one has the motivation to > improve wizard.cgi. > > > This patch makes kbugreport interact with enter_bug.cgi directly. It doesn't > really improve anything, but it comes as preparation for further work. There > is no functionality lost, since the feature of filling platform information > has been broken for a long time. > > Side note: As written in the TODO, I would like to make kbugreport correctly > fill OS and Platform information. The plan is stupid, just reuse/copy the > systeminformation.cpp[2] from drkonqi, which does a good job in guessing OS > and Platform for drkonqi. But I don't know whether such code duplication is > allowed or will interfere with the frameworks . > > [1] > http://commits.kde.org/websites/bugs-kde-org/491ded267e43faa79723fd31a9b64dd266a6f932 > [2] > https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/drkonqi/systeminformation.cpp > > > This addresses bug 291346. > http://bugs.kde.org/show_bug.cgi?id=291346 > > > Diffs > ----- > > kdeui/dialogs/kbugreport.cpp 2e72828 > > Diff: http://git.reviewboard.kde.org/r/108541/diff/ > > > Testing > ------- > > > Thanks, > > Jekyll Wu > >
