----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26748 -----------------------------------------------------------
kdecore/tests/kcompositejobtest.cpp <http://git.reviewboard.kde.org/r/108770/#comment20301> Extra White space kdecore/tests/kcompositejobtest.cpp <http://git.reviewboard.kde.org/r/108770/#comment20302> Same thing here - Dawit Alemayehu On Feb. 6, 2013, 11:33 a.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108770/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 11:33 a.m.) > > > Review request for kdelibs and Kevin Ottens. > > > Description > ------- > > Fix double-free in ~KCompositeJobPrivate > > In case a subjob of KCompositeJob has been deleted, this KCompositeJob > instance will crash as soon as it is being destructed, trying to delete > this subjob again. The reason for this is that KCompositeJob::addSubjob() > does not change the ownership of @p job. So, this job could be still > deleted by ~QObject() by the original parent. > > Add tests for this corner case. > > This fixes a bug in KDevelop. > > Backtrace: > 1 0x00007ffff7a3f28e in qDeleteAll<QList<KJob*>::const_iterator> > (end=..., begin=...) at /usr/include/qt4/QtCore/qalgorithms.h:322 > 2 qDeleteAll<QList<KJob*> > (c=QList<KJob *> = {...}) at > /usr/include/qt4/QtCore/qalgorithms.h:330 #3 > KCompositeJobPrivate::~KCompositeJobPrivate (this=0x8849850, > __in_chrg=<optimized out>) at ../../kdecore/jobs/kcompositejob.cpp:29 > 4 0x00007ffff7a3f2c9 in KCompositeJobPrivate::~KCompositeJobPrivate > (this=0x8849850, __in_chrg=<optimized out>) at > ../../kdecore/jobs/kcompositejob.cpp:30 > 5 0x00007ffff7a3fd70 in KJob::~KJob (this=0x880b030, > __in_chrg=<optimized out>) at > ../../kdecore/jobs/kjob.cpp:73 > 6 0x00007ffff1a8e5d9 in KDevelop::BuilderJob::~BuilderJob > (this=0x880b030, __in_chrg=<optimized > out>) at /home/krf/devel/src/kdevplatform/project/builderjob.cpp:158 > > BUG: 230692 > REVIEW: 108770 > FIXED-IN: 4.11 > > > This addresses bug 230692. > http://bugs.kde.org/show_bug.cgi?id=230692 > > > Diffs > ----- > > kdecore/jobs/kcompositejob.h 6ca8eed3ebf8c6f0f5c68d8843bd09a3ea928bbd > kdecore/jobs/kcompositejob.cpp 5ddabd71e5bbb5f0a555a201223a52950b85e786 > kdecore/tests/CMakeLists.txt f19e563d5d99ad2f2806140c5b21e38b20dbde0d > kdecore/tests/kcompositejobtest.h PRE-CREATION > kdecore/tests/kcompositejobtest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/108770/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > >