----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108711/#review26785 -----------------------------------------------------------
This review has been submitted with commit c517bbc175a3fbb09f13a8468a6987fdbc547d23 by Kevin Kofler to branch KDE/4.10. - Commit Hook On Feb. 2, 2013, 8:27 a.m., Kevin Kofler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108711/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2013, 8:27 a.m.) > > > Review request for kde-workspace, Christoph Feck and Oswald Buddenhagen. > > > Description > ------- > > Unfortunately, we cannot rely on the $PATH environment variable in KAuth > helpers, because D-Bus activation clears it. So we have to use a reasonable > default for the KStandardDirs::findExe search path, and actually use the > return value of KStandardDirs::findExe in the calls to KProcess::execute. > > This fixes things so hwclock and zic actually get found. See: > https://bugzilla.redhat.com/show_bug.cgi?id=906854 . This got noticed in > Fedora 18 because it does not always create /etc/localtime, so the fallback > code operating on /etc/localtime triggered an error. > > > Diffs > ----- > > kcontrol/dateandtime/helper.cpp 5a946d8 > > Diff: http://git.reviewboard.kde.org/r/108711/diff/ > > > Testing > ------- > > Builds against at least 4.10.0 and 4.9.5. > > Works at runtime on Fedora 18, see: > https://bugzilla.redhat.com/show_bug.cgi?id=906854#c12 (The reporter > encountered another issue, apparently because ktimezoned also misbehaves when > /etc/localtime is absent, but at least this particular issue is confirmed > fixed.) > > > Thanks, > > Kevin Kofler > >
