----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108442/#review27639 -----------------------------------------------------------
Ping? - Kai Uwe Broulik On Jan. 16, 2013, 6:18 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108442/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2013, 6:18 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > The KIconButton and the other occurences assume that the icon size for > desktop icons is always 48x48. This assumption is wrong. > This patch makes KPropertiesDialog use the proper IconSize. > > There are other places that need fixing too (eg. Dolphin's Place edit dialog > or KMenuEdit) which I will fix later as well. > > So, with KDE Frameworks at the horizon and kdelibs frozen, does this mean, > when I am re-writing the KIconDialog to be more userfriendly, use an UI file, > introduce new strings, etc this cannot go into master but only frameworks > branch? > > > Diffs > ----- > > kio/kfile/kicondialog.cpp b7d646f > kio/kfile/kpropertiesdialog.cpp 223ac7c > > Diff: http://git.reviewboard.kde.org/r/108442/diff/ > > > Testing > ------- > > Yup, you won't notice any difference with default settings but with higher > icon size and font scales perfectly and looks good. See screenshot. > > > File Attachments > ---------------- > > KPropertiesDialog with Retina settings > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png > > > Thanks, > > Kai Uwe Broulik > >
