> On March 17, 2013, 11:51 a.m., David Faure wrote: > > staging/sonnet/src/plugins/aspell/kspell_aspellclient.cpp, line 82 > > <http://git.reviewboard.kde.org/r/109531/diff/1/?file=120141#file120141line82> > > > > Doesn't the .json file need to exist? > > Alternatively I think the FILE argument can be empty, iirc.
Ah, forgot to add the json file... > On March 17, 2013, 11:51 a.m., David Faure wrote: > > staging/sonnet/src/core/client_p.h, line 78 > > <http://git.reviewboard.kde.org/r/109531/diff/1/?file=120139#file120139line78> > > > > Is this used anywhere? Funnily enough, the qobject_cast<Client *> in > > loadPlugin already compiles. > > Ah I see, that's because Client is a QObject, but it wouldn't need to > > be, with the interface stuff. AFAIK it needs to be a QObject for QPluginLoader to load it? - Martin Tobias Holmedahl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109531/#review29362 ----------------------------------------------------------- On March 16, 2013, 11:16 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109531/ > ----------------------------------------------------------- > > (Updated March 16, 2013, 11:16 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Description > ------- > > Port the ASpell plugin to the new style of doing plugins in Qt5. > > I'll do the rest of the plugins afterwards if this looks okay. > > > Diffs > ----- > > staging/sonnet/src/core/client_p.h cd5c0f2 > staging/sonnet/src/plugins/aspell/kspell_aspellclient.h 95173ff > staging/sonnet/src/plugins/aspell/kspell_aspellclient.cpp b649d0d > > Diff: http://git.reviewboard.kde.org/r/109531/diff/ > > > Testing > ------- > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >