> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: > > But why? KFileMetadataReader and the other KFileMetadataStuff should just > > be marked as deprecated. Why are we porting them? We already have better > > alternatives in the nepomuk-widgets repository.
Because it was a simple user of KProcess. But if we can just deprecate the whole class (and move it into kde4support, I guess?) that's better. :-) - Martin Tobias Holmedahl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109538/#review29377 ----------------------------------------------------------- On March 17, 2013, 1:26 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109538/ > ----------------------------------------------------------- > > (Updated March 17, 2013, 1:26 p.m.) > > > Review request for KDE Frameworks, kdelibs, David Faure, and Vishesh Handa. > > > Description > ------- > > KFileMetaDataReader currently uses KProcess, this ports it to use QProcess > instead. > > > Diffs > ----- > > kio/kfile/kfilemetadatareader.cpp 88cadaa > > Diff: http://git.reviewboard.kde.org/r/109538/diff/ > > > Testing > ------- > > it builds. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
