> On March 22, 2013, 6:20 a.m., Laurent Montel wrote: > > You need to increase attica version and make kdelibs depends against it. > > Otherwise it will not compile. > > We can't depends against git master version, we must have a official release > > regards. > > Sven Brauch wrote: > Ah, yes. So, I would increase attica's version from 0.4.1 to 0.4.2 and > make kdelibs master depend on that?
Yes - Laurent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29671 ----------------------------------------------------------- On March 18, 2013, 5:41 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109568/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 5:41 p.m.) > > > Review request for Attica, kdelibs and Jeremy Paul Whiting. > > > Description > ------- > > When the provider file lists an URL to register a new account, this patch > adds a link to the login screen of the upload dialog which enables a user to > register a new account. > > This patch depends on https://git.reviewboard.kde.org/r/109567/. > > > Diffs > ----- > > knewstuff/knewstuff3/uploaddialog.h 3f58f7d > knewstuff/knewstuff3/uploaddialog.cpp 922469e > knewstuff/knewstuff3/uploaddialog.ui aa54d2b > knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 > > Diff: http://git.reviewboard.kde.org/r/109568/diff/ > > > Testing > ------- > > > Thanks, > > Sven Brauch > >
