On Tuesday 16. April 2013 16.30.15 Rolf Eike Beer wrote: > Am Dienstag 16 April 2013, 13:26:23 schrieb Frederik Gladhorn: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/110042/ > > ----------------------------------------------------------- > > > > Review request for kdelibs. > > > > > > Description > > ------- > > > > Build fix for dbusmenu qt5 changes. > > This appends the 5 to include path and lib dir in the find module. > > Also rename the whole thing to not conflict with the Qt 4 version. > > Since DBusMenuQt5 is obviously a rather new thing I would vote for putting a > DBusMenuQt5Config.cmake into that project itself and install that. That > would allow everyone to use it with CMake once the module itself is > installed, without any need for a Find*.cmake module.
I agree, that would make sense. If anyone is up for doing that (the code is in launchpad) feel free to do so, I will not get around to doing that. I can abandon this patch in favor of the Config.cmake file. I mostly wanted to build kdelibs-frameworks and this patch is actually pretty small (I just renamed the .cmake file for clarity's sake). Greetings Frederik > > Eike
