----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110247/#review31875 -----------------------------------------------------------
Ship it! Looks good, just two minor things to fix, then commit. kurifilter-plugins/ikws/searchproviderdlg.cpp <http://git.reviewboard.kde.org/r/110247/#comment23774> Just <QClipboard>, for Qt5 compatibility. kurifilter-plugins/ikws/searchproviderdlg.cpp <http://git.reviewboard.kde.org/r/110247/#comment23775> The argument is not necessary, Clipboard is the default value. - David Faure On April 30, 2013, 11:46 a.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110247/ > ----------------------------------------------------------- > > (Updated April 30, 2013, 11:46 a.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > When making a new web shortcut check the clipboard, if it's a url put it in > the query line edit. > Just a little time saver. (akregator does something similar) > > I used !host().isEmpty() because isValid() is almost always valid. > This will give false positives where the wrong link is placed inside the > query box. > > > This addresses bug 146880. > http://bugs.kde.org/show_bug.cgi?id=146880 > > > Diffs > ----- > > kurifilter-plugins/ikws/searchproviderdlg.cpp 2bb2852 > > Diff: http://git.reviewboard.kde.org/r/110247/diff/ > > > Testing > ------- > > Tested some url's and some random text. Only a url gets selected from the > clipboard. > > > Thanks, > > Maarten De Meyer > >
