-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review31963
-----------------------------------------------------------


any news on this?
Martin, what do you think about it?

- Marco Martin


On March 23, 2013, 8:06 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107983/
> -----------------------------------------------------------
> 
> (Updated March 23, 2013, 8:06 p.m.)
> 
> 
> Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, 
> Martin Gräßlin, and Marco Martin.
> 
> 
> Description
> -------
> 
> It works fine here (tested so far KWindowSystem signal, KSelectionWatcher 
> only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" 
> and e17.
> Didn't try xfce nor mutter.
> 
> Technically:
> I do not at all understand why KWindowSystem is *not* watching the root 
> window - KSelectionOwner for one is sending events to the root and this also 
> seems the case for all other WMs (at least everything now starts to cause the 
> signal to be emitted)
> 
> The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner 
> testcase), there'll be some X11 event processing on top that eats away the 
> client messages.
> So this one can be scratched from the patch, the KWindowSystem issue remains.
> 
> 
> This addresses bug 179042.
>     http://bugs.kde.org/show_bug.cgi?id=179042
> 
> 
> Diffs
> -----
> 
>   kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107983/diff/
> 
> 
> Testing
> -------
> 
> see summary
> 
> 
> File Attachments
> ----------------
> 
> testcase
>   
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

Reply via email to