----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32111 -----------------------------------------------------------
Thanks for taking care of this! Just a few comments. dolphin/src/dolphinpart.cpp <http://git.reviewboard.kde.org/r/108802/#comment23909> This if() is not useful, delete NULL is fine. dolphin/src/dolphinpart.cpp <http://git.reviewboard.kde.org/r/108802/#comment23910> Shouldn't this be done only if addDel is true, as it was before? dolphin/src/dolphinpart.cpp <http://git.reviewboard.kde.org/r/108802/#comment23911> Same code as in dolphincontextmenu. If it can't be shared, at least there should be a comment about where the code comes from, for easier maintainance. dolphin/src/dolphinpart.cpp <http://git.reviewboard.kde.org/r/108802/#comment23912> There are other ways to bring the context menu than the right button. There's the context key, too. So better watch for the QEvent::ContextMenu event instead of hardcoding "release of right button", if it really has to be done with the event filter. - David Faure On May 5, 2013, 1:53 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108802/ > ----------------------------------------------------------- > > (Updated May 5, 2013, 1:53 p.m.) > > > Review request for KDE Base Apps, David Faure and Frank Reininghaus. > > > Description > ------- > > This patch fixes DolphinPart such that the "Delete/Move To Trash" actions are > automatically toggled if the user presses the Shift key and allows > https://git.reviewboard.kde.org/r/107509/ to be applied. > > The code is completely based on what Dolphin's context menu does. Even though > this works as planned, I still have reservations about the use of > KModifierKeyInfo since every key press event from any application is sent to > the application that connects to its signals. In my code and unlike what is > done in Dolphin's context menu, I try to mitigate the impact of that by > ignoring the signal when the part does not have the focus. Still if there is > a better way to capture key press events at the part level I would like to > use that instead. Any ideas ? > > > Diffs > ----- > > dolphin/src/dolphinpart.h 7881ded > dolphin/src/dolphinpart.cpp 627ba79 > > Diff: http://git.reviewboard.kde.org/r/108802/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
