----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32149 -----------------------------------------------------------
Looks very reasonable from my point of view, thanks! And yes, https://bugs.kde.org/show_bug.cgi?id=304775 can be closed when this is pushed. Thanks for the hint, Emmanuel! kdeui/widgets/kmessagewidget.cpp <http://git.reviewboard.kde.org/r/110327/#comment23939> I guess you can remove the variable 'icon' from this function now, right? - Frank Reininghaus On May 6, 2013, 3:53 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110327/ > ----------------------------------------------------------- > > (Updated May 6, 2013, 3:53 p.m.) > > > Review request for Dolphin, Kate and kdelibs. > > > Description > ------- > > This avoids confusion between the decoration icon and the close button, > especially when type is KMessageWidget::Error. This happens for example with > Dolphin when an error happens while trying to connect to an non available > host. > This change also has the nice side-effect of leaving more space for the > widget text. > > > Diffs > ----- > > kdeui/widgets/kmessagewidget.cpp a52316726233a22929ce8ad3aff60b9ccc5f9b85 > > Diff: http://git.reviewboard.kde.org/r/110327/diff/ > > > Testing > ------- > > Tested with kmessagewidgetdemo, Dolphin and Kate. > > > Thanks, > > Aurélien Gâteau > >
