----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110430/#review32545 -----------------------------------------------------------
I am not in favour of this patch for a couple of reasons. First, there is a port underway to QML which does not need to be delayed further by adding more features. More importantly, however, "middle click" is a special case of "not the first two mouse buttons" (should we support N button mice?) and it adds yet more configuration to an already complex and full configuration dialog. It also conflicts with the meaning of middle click to expand / collapse groups (a fairly hidden feature I also was not particularly happy with tbh). - Aaron J. Seigo On May 14, 2013, 10:35 p.m., Albert Vaca Cintora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110430/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 10:35 p.m.) > > > Review request for kde-workspace and Plasma. > > > Description > ------- > > This patch adds a feature present in KDE3 and requested by some users (see > open bugs), that is performing an action when a taskbar entry is > middle-clicked. I have added three possible actions: Close the application, > hide it or move it to the current desktop, where the first two were user > requests. > > > This addresses bugs 182689 and 190951. > http://bugs.kde.org/show_bug.cgi?id=182689 > http://bugs.kde.org/show_bug.cgi?id=190951 > > > Diffs > ----- > > plasma/desktop/applets/tasks/tasks.h fe79a12 > plasma/desktop/applets/tasks/tasks.cpp 0a86dcf > plasma/desktop/applets/tasks/tasksConfig.ui 6f3ff18 > plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 > > Diff: http://git.reviewboard.kde.org/r/110430/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Albert Vaca Cintora > >