----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ -----------------------------------------------------------
(Updated May 17, 2013, 12:11 p.m.) Review request for kdelibs. Description ------- This implemets a step in the kdeui crumble epic. moves the classes kstatusnotifieritem and knotificationsrestrictions in the knotifiactions library. The patch works, but there are still several issues: * porting from kdebug to qdebug loses the area number * adds some link libraries: the classes add ki18n, kwidgets and KWidgetsAddons * the test adds ki18n kde4support kdecore * the KActionCollection becomes a qhash of actions: how should be kactioncollections ported? I guess it should use the qt translation system, and redo the quit dialog to not usekstandardgui at all? Diffs ----- kdeui/CMakeLists.txt cfa29ef kdeui/tests/CMakeLists.txt cd055d5 staging/knotifications/src/CMakeLists.txt 266b67c staging/knotifications/src/knotificationrestrictions.cpp a396fd6 staging/knotifications/src/kstatusnotifieritem.h be21882 staging/knotifications/src/kstatusnotifieritem.cpp 37abe7e staging/knotifications/src/kstatusnotifieritemdbus_p.cpp 6c9e1da staging/knotifications/src/kstatusnotifieritemprivate_p.h 32e7906 staging/knotifications/tests/CMakeLists.txt 2240a69 staging/knotifications/tests/kstatusnotifieritemtest.cpp 38e85ac Diff: http://git.reviewboard.kde.org/r/110482/diff/ Testing ------- Thanks, Marco Martin