> On Feb. 8, 2013, 6:23 p.m., Albert Astals Cid wrote: > > What's the status on this? Should be discarded? Reworked? > > Patrick Spendrin wrote: > It needs to be reworked, because I doubt that the issue has vanished by > not looking at it.
Ok, steveire fixed this in cmake upstreams. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105452/#review26991 ----------------------------------------------------------- On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105452/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 1:09 p.m.) > > > Review request for kdelibs, David Faure, Alexander Neundorf, and Stephen > Kelly. > > > Description > ------- > > This fix is needed for some custom exports on windows. Given there is no > KDE_EXPORT anymore, I use Q_DECL_EXPORT for now. See also the discussion on > kde-frameworks-de...@kde.org. > > > Diffs > ----- > > kdecore/localization/ktranscript.cpp 08ebf0e > kdecore/util/kexportplugin.h 775ed48 > > Diff: http://git.reviewboard.kde.org/r/105452/diff/ > > > Testing > ------- > > windows only. > > > Thanks, > > Patrick Spendrin > >
