> On June 17, 2013, 6:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wrote: > The syntax seems to be a bit different :-/ > > -# GETTEXT_PROCESS_POT( <potfile> [ALL] [INSTALL_DESTINATION <destdir>] > LANGUAGES <lang1> <lang2> ... ) > +# GETTEXT_PROCESS_POT( <potfile> [ALL] [INSTALL_DESTINATION <destdir>] > <lang1> <lang2> ... ) > > > Andrea Scarpino wrote: > They have the same signature here, cmake 2.8.11.1
Ok, now I actually looked at the files. The one from kdelibs: GETTEXT_PROCESS_POT( <potfile> [ALL] [INSTALL_DESTINATION <destdir>] <lang1> <lang2> ... ) the one in cmake: GETTEXT_PROCESS_POT( <potfile> [ALL] [INSTALL_DESTINATION <destdir>] LANGUAGES <lang1> <lang2> ... ) I'm not sure whether there was a reason why I didn't add that difference to http://techbase.kde.org/Development/ECM_SourceIncompatChanges#FindGettext.cmake Is this used somewhere ? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34508 ----------------------------------------------------------- On June 17, 2013, 3:26 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111068/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 3:26 p.m.) > > > Review request for kdelibs and Alexander Neundorf. > > > Description > ------- > > Use GETTEXT_MSGFMT_EXECUTABLE from #FindGettext.cmake coming with CMake > instead. > > > Diffs > ----- > > cmake/modules/CMakeLists.txt 25ea009 > cmake/modules/FindMsgfmt.cmake 47c6121 > > Diff: http://git.reviewboard.kde.org/r/111068/diff/ > > > Testing > ------- > > > Thanks, > > Andrea Scarpino > >