----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951/#review34765 -----------------------------------------------------------
Ship it! ok, so tested it myself it works, code looks good... ship it! - Àlex Fiestas On June 11, 2013, 1:36 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110951/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 1:36 p.m.) > > > Review request for kdelibs and Àlex Fiestas. > > > Description > ------- > > Save icon size in the same place other settings are saved > > This ensures icon size changes in KFileDialog are correctly stored in > kdeglobals. > > > Diffs > ----- > > kfile/kdiroperator.cpp d7bd4cfb44952f917c3d42a7794e0b7e7cbfb5bd > > Diff: http://git.reviewboard.kde.org/r/110951/diff/ > > > Testing > ------- > > 1. Started KWrite > 2. Opened file dialog > 3. Changed icon size > 4. Closed file dialog > 5. Started Gwenview > 6. Opened file dialog => same icon size as the one set on step 3. > > > Thanks, > > Aurélien Gâteau > >