> On June 20, 2013, 8:22 a.m., David Faure wrote: > > I see the idea. The only downside I can think of is that on login, the kded > > modules will be loaded later (after kbuildsycoca finishes), which might > > slow down the overall startup process, if other apps are waiting on these > > modules? Well, maybe they'll get loaded on demand when the apps make calls > > to them... > > > > Well, please test startkde if you haven't done so already. > > Àlex Fiestas wrote: > That seems to be already the case, from current code (without the path): > > -recreate(true is called) > -runBuildSycoca is called without callback (making it sync) > -then initModules is called (from newInstance) > > This patch only moves initModules to be called within ::recreate. > > Is the stated before right or I'm missing something? >
Ah, OK. But then.... the modules won't be found, on first boot, since their desktop files aren't in ksycoca yet, right? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111145/#review34731 ----------------------------------------------------------- On June 19, 2013, 10:04 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111145/ > ----------------------------------------------------------- > > (Updated June 19, 2013, 10:04 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > When syscoca gets dirty (modules added/removed for example) modules are not > being updated, so if a new module has been added it won't be loaded until > kded is restarted. > > This patch executes initModules (that seems to be completely ready for the > task) when recreate is done. > > > Diffs > ----- > > kded/kded.cpp bd63726 > > Diff: http://git.reviewboard.kde.org/r/111145/diff/ > > > Testing > ------- > > Restarted kded (to check that all modules load at launch). > Added/removed modules and check if they get loaded/unloaded. > > > Thanks, > > Àlex Fiestas > >
