----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review35347 -----------------------------------------------------------
Not that I could comment on whether it's useful or not on Windows, but my recommendation is to remove the complete "Graphical Information" subtree on Windows. kinfocenter/Modules/base/os_base.h <http://git.reviewboard.kde.org/r/111342/#comment25898> why is this else part needed? If something is still accessing Display it should probably better be ifdefed there. - Martin Gräßlin On July 1, 2013, 1:33 p.m., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111342/ > ----------------------------------------------------------- > > (Updated July 1, 2013, 1:33 p.m.) > > > Review request for kde-workspace and kwin. > > > Description > ------- > > make kinfocenter compile on non x11 systems and Windows > Kinfocenter is quite useful to test a solid backend > > > Diffs > ----- > > CMakeLists.txt 57cd82c56539b93fafe7866a259c155eebcc86a0 > kinfocenter/Modules/CMakeLists.txt 0a87eb48d97df2e0224819225ba0af6bf0d93f39 > kinfocenter/Modules/base/os_base.h f09202d9d0c592238735dc1b2d5041a921358adb > kinfocenter/Modules/devinfo/soldevicetypes.cpp > d3387d972b14368e9fa2b5ad1f97d5210d2beb01 > > Diff: http://git.reviewboard.kde.org/r/111342/diff/ > > > Testing > ------- > > windows > > > Thanks, > > Patrick von Reth > >
