-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111272/
-----------------------------------------------------------

(Updated July 2, 2013, 2:41 a.m.)


Review request for kdelibs and David Faure.


Changes
-------

Properly address this problem such that it is fixed for use cases the previous 
version of the patch ignored.


Description
-------

The attached patch addresses a bug where a user enters the name of a KDE 
application in OpenWith dialog to open a remote file and the file is opened as 
if the user requested to open it with a non KDE application. That is a local 
copy of the file is created first. Currently this problem can be reproduced 
with kate because the "Exec=" line in its desktop file contains an additional 
option, "-b".

Note that this patch only addresses the specific condition where the user only 
typed in the KDE executable name. Other scenarios, like the user typing in not 
only the name of the KDE app but also additional command line options, will 
still produce this same issue.


This addresses bug 222519.
    http://bugs.kde.org/show_bug.cgi?id=222519


Diffs (updated)
-----

  kdecore/services/kservice.h 3843bad 
  kdecore/services/kservice.cpp e2cc86f 
  kio/kfile/kopenwithdialog.cpp 84465cd 

Diff: http://git.reviewboard.kde.org/r/111272/diff/


Testing
-------

Try to open a remote text or source file by typing "kate" in the open with 
dialog.


Thanks,

Dawit Alemayehu

Reply via email to