----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111345/#review35426 -----------------------------------------------------------
Ship it! Makes sense. - David Faure On July 1, 2013, 4:01 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111345/ > ----------------------------------------------------------- > > (Updated July 1, 2013, 4:01 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > When the StatusBarExtension receives a GUIActivateEvent, it shows or hides > its statusbar items accordingly, but it does not remember it: if an item is > added after receiving a GUIActivateEvent(false), the item will be shown. This > patch adds a bool m_activated field to keep track of the state and take it > into account when a new item is added. > > This change is needed for an Akregator fix: > https://git.reviewboard.kde.org/r/111346/ . Without the patch, when Akregator > restores its session at startup, the statubar items for all background tabs > appear. > > > Diffs > ----- > > kparts/statusbarextension.cpp db7e4197dd42497f91c66d1654e9b1c8cc45d793 > > Diff: http://git.reviewboard.kde.org/r/111345/diff/ > > > Testing > ------- > > Akregator startup: statusbar items do not appear when the main tab is focused > and other tabs are loaded. Statusbar items do appear when the corresponding > tab is focused. > > Konqueror: played around with tabs and splitted views, did not notice any > behavior change in the statusbar. > > > Thanks, > > Aurélien Gâteau > >
