----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111379/#review35519 -----------------------------------------------------------
Is the + 1 really required? It does not hurt to be extra safe, though. - Christoph Feck On July 3, 2013, 1:54 p.m., Róbert Szókovács wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111379/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 1:54 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Buffersize fix for the patch in #110043. > > > This addresses bug 321870. > http://bugs.kde.org/show_bug.cgi?id=321870 > > > Diffs > ----- > > kdecore/localization/klocale_kde.cpp db4af81 > > Diff: http://git.reviewboard.kde.org/r/111379/diff/ > > > Testing > ------- > > Yes, the old code works with strings that has only one non-UTF-non-ASCII > character and crashes if there is more. The patched version allocates the > correct amount of buffer. > > > Thanks, > > Róbert Szókovács > >