> On July 15, 2013, 10:49 a.m., Aaron J. Seigo wrote:
> > i think that technically this is a bug in the applications triggering it, 
> > but i agree we should probably work around it. the performance of the patch 
> > is theoretically bad (linear time), but hopefully nobody is storing 1000s 
> > and 1000s of notifications in that UI .. in fact, i'm certain other 
> > problems would interfere before then ;)
> 
> Cedric Bellegarde wrote:
>     Should i backport to KDE/4.11 or not ?

yes, it is a bugfix  :)


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111480/#review35959
-----------------------------------------------------------


On July 15, 2013, 9:18 a.m., Cedric Bellegarde wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111480/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 9:18 a.m.)
> 
> 
> Review request for kde-workspace and Marco Martin.
> 
> 
> Description
> -------
> 
> Do not replace notifications with same summary and body 
> 
> Here a patch similar to this colibri commit.
> 
> See REVIEW: 110745
> http://quickgit.kde.org/?p=colibri.git&a=commit&h=9a96b9512579215bcddd8fc88041fdd7130dbb0f
> 
> 
> This addresses bug 313440.
>     http://bugs.kde.org/show_bug.cgi?id=313440
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/Notifications.qml ce3f8de 
> 
> Diff: http://git.reviewboard.kde.org/r/111480/diff/
> 
> 
> Testing
> -------
> 
> Working here
> 
> 
> Thanks,
> 
> Cedric Bellegarde
> 
>

Reply via email to