> On July 21, 2013, 4:47 p.m., Albert Astals Cid wrote: > > Is that qt change really needed? Otherwise we are a bit past the dependency > > freeze > > Christoph Feck wrote: > CMakeLists.txt already requires Qt 4.8.0.
But isn't the content of CMakeLists.txt for kdelibs and the content in that file for something using kdelibs, right? Do we need to mandate 4.8 on them too? In other words, could i compile a program against qt 4.5 and a kdelibs compiled with qt 4.8? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111633/#review36261 ----------------------------------------------------------- On July 21, 2013, 4:40 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111633/ > ----------------------------------------------------------- > > (Updated July 21, 2013, 4:40 p.m.) > > > Review request for Build System, kdelibs and Alexander Neundorf. > > > Description > ------- > > Not sure at which point in time we update the KDE version. > > Additionally, I changed the required Qt version, in the hope that build > system maintainers find more spots where version updates might be required. > > > Diffs > ----- > > cmake/modules/FindKDE4Internal.cmake 98a6f48 > > Diff: http://git.reviewboard.kde.org/r/111633/diff/ > > > Testing > ------- > > > Thanks, > > Christoph Feck > >
