On Sunday 21 July 2013, Rolf Eike Beer wrote: > Am Sonntag, 21. Juli 2013, 14:11:07 schrieb Volker Krause: > > On Sunday 21 July 2013 13:52:06 Rolf Eike Beer wrote: > > > Volker Krause wrote: > > > > - GCC >= 4.5 > > > > > > > > - override > > > > > > Explicit virtual overrides require g++ 4.7: > > > > > > http://gcc.gnu.org/projects/cxx0x.html > > > > you are right, it's also what all other sources referenced in > > http://article.gmane.org/gmane.comp.kde.devel.frameworks/3652 say, no > > idea how that slipped in then, sorry. > > > > > This is trivially to work around by a CMake time check and then just > > > define > > > override to empty. > > > > sure, for KF5 this is not really a problem since Qt provides > > corresponding macros already. I was hoping for real unconditional usage > > though, since Akonadi will need to stay backward-compatible with Qt4 for > > a while longer, and I wanted to avoid to have to basically copy > > qcompilerdetection.h for that. Not to mention that "override" looks much > > nicer than > > "Q_DECL_OVERRIDE" ;) > > I totally agree with that. As I said: detection of this is trivial at CMake > time, maybe I get my C++ feature detection package ready even to be > included in 2.8.12, and if not the stuff can easily be extracted. And
Yes, that would be great :-) You still wanted to have a rweview, right ? Alex