> On July 30, 2013, 1:28 p.m., Sebastian Kügler wrote: > > Not so sure about this. The 3 char restriction is there for performance, it > > might still work as expected on many system, yet cause stalling on others. > > At least doing the query on the first character seems *way* overdone.
Compromise: for < 3 chars, trigger a 500ms timer. So if a user types and waits he gets a reply but you won't burden the system with finding everything on the first key press. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111795/#review36804 ----------------------------------------------------------- On July 30, 2013, 12:46 p.m., Milo Mordaunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111795/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 12:46 p.m.) > > > Review request for kde-workspace. > > > Description > ------- > > The services runner now queries with terms of less than three characters. > > Previously with a term of less than three characters this runner would be > idle. Now it gives more immediate results, ie gp now returns gparted., and > since it is only the services runner they are likely to be relevant. > > > Diffs > ----- > > plasma/generic/runners/services/servicerunner.cpp > 7b292efe40bbddb23cfc317648db0e645c579879 > > Diff: http://git.reviewboard.kde.org/r/111795/diff/ > > > Testing > ------- > > I have tested a variety of terms in my krunner, and the services runner > appears to be working as expected. > > > Thanks, > > Milo Mordaunt > >
