----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37476 -----------------------------------------------------------
Good start. You shouldn't delete the Messages.sh file. Copy from something that already uses QML, such as the battery applet. There's also a change from the current behaviour. The current one only shows where state = Running, it appears yours shows everything. Is this intentional? plasma/generic/applets/activitybar/package/contents/ui/main.qml <http://git.reviewboard.kde.org/r/111992/#comment27711> Is this needed? We shouldn't be polling, only updating where there's changes. plasma/generic/applets/activitybar/package/contents/ui/main.qml <http://git.reviewboard.kde.org/r/111992/#comment27710> Does this mean that if there's a new activity created whilst we're running, we won't connect to it. plasma/generic/applets/activitybar/package/contents/ui/main.qml <http://git.reviewboard.kde.org/r/111992/#comment27709> Remove this :) - David Edmundson On Aug. 10, 2013, 4:39 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111992/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2013, 4:39 p.m.) > > > Review request for kde-workspace and Marco Martin. > > > Description > ------- > > Activity bar applet ported in QML. > > > Diffs > ----- > > plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb > plasma/generic/applets/activitybar/Messages.sh e73df21 > plasma/generic/applets/activitybar/activitybar.h b95cb0c > plasma/generic/applets/activitybar/activitybar.cpp e66bf04 > plasma/generic/applets/activitybar/package/contents/ui/main.qml > PRE-CREATION > plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION > plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop > b7155de > > Diff: http://git.reviewboard.kde.org/r/111992/diff/ > > > Testing > ------- > > Works, Tested in plasmoidviewer and desktop > > > Thanks, > > Bhushan Shah > >
