> On Aug. 12, 2013, 8:50 a.m., Marco Martin wrote: > > plasma/generic/applets/activitybar/package/contents/ui/main.qml, line 37 > > <http://git.reviewboard.kde.org/r/111992/diff/5/?file=178116#file178116line37> > > > > whitespace s your friend > > > > for (i=0; i<activitySource.sources.length; i++) {
even better, for (i = 0; i < activitySource.sources.length; i++) { - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37558 ----------------------------------------------------------- On Aug. 12, 2013, 3:14 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111992/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 3:14 a.m.) > > > Review request for kde-workspace and Marco Martin. > > > Description > ------- > > Activity bar applet ported in QML. > > > Diffs > ----- > > plasma/generic/applets/activitybar/CMakeLists.txt 51a2edb > plasma/generic/applets/activitybar/Messages.sh e73df21 > plasma/generic/applets/activitybar/activitybar.h b95cb0c > plasma/generic/applets/activitybar/activitybar.cpp e66bf04 > plasma/generic/applets/activitybar/package/contents/ui/main.qml > PRE-CREATION > plasma/generic/applets/activitybar/package/metadata.desktop PRE-CREATION > plasma/generic/applets/activitybar/plasma-applet-activitybar.desktop > b7155de > > Diff: http://git.reviewboard.kde.org/r/111992/diff/ > > > Testing > ------- > > Works, Tested in plasmoidviewer and desktop > > > Thanks, > > Bhushan Shah > >