> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop file > affect Linux here? > > Pali Rohár wrote: > In desktop file is bug. Thumbnail for "application/x-win-lnk" is not > supported by this plugin, so it should be removed - and it fixing by this > patch. > > I already proposed it in my patch https://svn.reviewboard.kde.org/r/5156/ > but in Qt is *bug* which caused that my patch not working correctly. My patch > removed dependency on icoutils and used only Qt functions. But due to Qt bug > it not worked. (See that review request). > > What is preferred way to fix bugs in Qt4 which affects KDE? > > Patrick Spendrin wrote: > You should fix the bug in the 5.X version of Qt and backport it to Qt4. > You must let the patch be reviewed on http://codereview.qt-project.org/ (see > http://qt-project.org/wiki/Gerrit-Introduction and > http://qt-project.org/wiki/Setting-up-Gerrit how to do that). > > Pali Rohár wrote: > I have no motivation to try it again. I pushed my patch to nokia qt bug > tracker 3 years ago, but nobody look at it. Next, I created merge request on > qt gitorious project and waited... and then was merge request removed due to > migration from gitorious... > > So if you can push it to review for me, I will prepare patch again.
If you can prepare that patch, I can try to get it in instead. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review37623 ----------------------------------------------------------- On Aug. 11, 2013, 1:59 p.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112009/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2013, 1:59 p.m.) > > > Review request for KDE Runtime, kdewin and Pali Rohár. > > > Description > ------- > > This patch intends to enable Windows exe/dll thumbnailing by using winapi. It > derives from the unsubmitted patch from Pali Rohár from > https://svn.reviewboard.kde.org/r/5156/ as a starting point. I've made a few > adjustments on the original patch, split that patch into a common part and a > icoutils-specific part, and then created the winapi-based part to replace the > icoutils one on Windows (porting icoutils to windows wasn't going to be easy). > > > Diffs > ----- > > kioslave/thumbnail/CMakeLists.txt b81339b > kioslave/thumbnail/icoutils.h 6468bc1 > kioslave/thumbnail/icoutils.cpp 31db85d > kioslave/thumbnail/icoutils_common.cpp PRE-CREATION > kioslave/thumbnail/icoutils_icotools.cpp PRE-CREATION > kioslave/thumbnail/icoutils_win.cpp PRE-CREATION > kioslave/thumbnail/windowsexecreator.h a407982 > kioslave/thumbnail/windowsexecreator.cpp 9e24aee > kioslave/thumbnail/windowsexethumbnail.desktop f10efef > kioslave/thumbnail/windowsimagecreator.h 0b68cc6 > kioslave/thumbnail/windowsimagecreator.cpp 08b063d > > Diff: http://git.reviewboard.kde.org/r/112009/diff/ > > > Testing > ------- > > Tested on a Windows 7 64-bit machine, with intel compiler (32-bit). > Tested using ico files and both 32-bit and 64-bit executables and dlls, > including jumbo-size icons. > I've used QLibrary for all winapi functions in order to avoid issues with > MinGW compiler, but I don't have a MinGW setup to check. > > Not tested on *nix, but the original patch was not changed except for > iterating order in the common part and namespacing. > > > File Attachments > ---------------- > > screenshot > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png > > > Thanks, > > Andrius da Costa Ribas > >
