> On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote: > > Ship It! > > Gabi Sarkis wrote: > Sorry about that. How do I go about "Shipping it"? > > Thanks > > Yuri Chornoivan wrote: > Just commit it into the repo or ask someone to do it for you. > > Commit message should contain a separate string "REVIEW: 111952" to close > this RR.
Gabi, Let me know if you don't have a kde account and I'll commit the fix to git myself. - Jeremy Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111952/#review37713 ----------------------------------------------------------- On Aug. 8, 2013, 1:12 p.m., Gabi Sarkis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111952/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 1:12 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Currently, the mimetypes used to check xz and lzma packages downloaded by > knewstuff are those of compressed files: application/x-xz and > application/x-lzma. Downloads from kdelooks are provided as compressed tar > archives. > This patch corrects the mimetypes to those of compressed archives. > > > This addresses bug 287913. > http://bugs.kde.org/show_bug.cgi?id=287913 > > > Diffs > ----- > > plasma/package.cpp cd3702c > > Diff: http://git.reviewboard.kde.org/r/111952/diff/ > > > Testing > ------- > > Tested locally and the Plasma themes Helium and Silicon are now correctly > extracted and installed from the Workspace Appearance KCM. > > > Thanks, > > Gabi Sarkis > >