> On Aug. 26, 2013, 12:27 p.m., David Faure wrote: > > kdecore/services/kservice.cpp, line 236 > > <http://git.reviewboard.kde.org/r/111951/diff/4/?file=183924#file183924line236> > > > > Ah, I forgot to ask: why this check? > > > > Surely the same applies to parts and plugins, doesn't it?
The bug (321706) really only applies to applications, so I thought to save some time one could check only applications. But if you wish I can remove the check. I did some checks on my system with the check removed and it takes about 50ms more to finish a kbuildsycoca4 --nocinremental call, so the gain is quite minimal. > On Aug. 26, 2013, 12:27 p.m., David Faure wrote: > > kdecore/services/kservice.cpp, line 240 > > <http://git.reviewboard.kde.org/r/111951/diff/4/?file=183924#file183924line240> > > > > this kind of iteration is convenient for modifying the list (or peeking > > ahead, like the parent loop does), but here a simple foreach() would do, > > right? Agreed, I will change that to a foreach loop. - Mathias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111951/#review38615 ----------------------------------------------------------- On Aug. 26, 2013, 1:08 p.m., Mathias Tillman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111951/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2013, 1:08 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > This fixes a bug introduced by > https://projects.kde.org/projects/kde/kdelibs/repository/revisions/871cccc8a88a600c8f850a020d44bfc5f5858caa > that made it impossible to re-order file type associations both in System > settings and in the open with list. Hence it contains a new way of detecting > duplicate (inherited) mimetype entries, that the original was supposed to fix. > > > This addresses bug 321706. > http://bugs.kde.org/show_bug.cgi?id=321706 > > > Diffs > ----- > > kdecore/services/kservice.cpp 8e81929b91803a3eed586d9fc15cdd78165b6bce > kded/kbuildservicefactory.cpp 7f89a991d088476d8ed94763e6fa65dcc3d0603c > kded/kmimeassociations.h 4a2c71312ade32a9ac779495496bf6ebb78b37a4 > kded/kmimeassociations.cpp b0af7bcc4a39e5cce1fa6abe86cace476313702a > > Diff: http://git.reviewboard.kde.org/r/111951/diff/ > > > Testing > ------- > > I have tested so that file type associations can be ordered correctly, in > addition to making sure that parent mimetypes have precedence when an app > lists two or more mimetypes where one is the parent of the other. > > > Thanks, > > Mathias Tillman > >
