El Diumenge, 25 d'agost de 2013, a les 12:05:11, Valentin Rusu va escriure: > On 08/24/2013 01:43 PM, Albert Astals Cid wrote: > > El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: > >> * Another piece of software related to kwallet is KWalletManager from > >> kdeutils. I think that component should also be detached from kdeutils > >> and attached under kwallet/src/manager. I can also handle this task if > >> that's OK (Aron, David, Kevin but also Raphael?) > > > > Not sure this bundling makes sense. KWalletManager is a tool that if i am > > a > > developer for Windows that wants to use the kwallet framework I don't > > need. > > Actually it's a utility a regular user should probably never need unless > > you use it to manually store stuff (I do) or you want to inspect what > > apps store (I do). > > I also use the KWalletManager on windows as a secret storing tool, at my > workplace. The other KDE components I use at work do not seem to use the > kwalletd. Chrome for Windows do not detect kwallet as it does under > Linux. So, AFAICT, Windows users are interested by using KWalletManager, > and this requires kwalletd, which is packaged separately. I think that > even for this case we should bundle these components together. That > would also help other contributors better understand kwallet's structure > and allow them contribute more easily.
If you bundle lots of stuff in the tarball you may end up "wrongly" increasing your dependencies and people won't use the framework because "it depends on QtNetwork" or some other stuff that it's only used in kwalletmanager. Please let's not bundle stuff just because it's easier when there's a lot of people unbundleing stuff because it's better. Cheers, Albert > > > Of course I don't have much of a decision power on this but wanted to > > express my concerns ;-) > > > > Cheers and congratulations for your new maintainership, > > > > Albert > > Thanks