> On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote: > > I have several changes coming to this ioslave. Mainly I am going to > > implement the copyFrom and copyTo optimizations like I did for the sftp > > ioslave and add support for upload/download resumptions. The changes are > > going to come in parts because they are not small and should be done in the > > next week or two. > > > > If you feel that it would be easier to merge those changes after your port, > > then feel free to ship this, otherwise would it be possible for you to hold > > off on this port? For the record I am not the maintainer of this code base. > > I am just trying to improve as many of these ioslaves as I can when I get > > the chance.
Question though: did you test this port and did it work for you? As for the porting and your changes. You seem to be making those changes in KDE/4.11, not in frameworks-scratch, so i would prefer if you make the changes you want to make. Once those are in i will have to rebase my changes against it and request a "ship it" again :) - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39463 ----------------------------------------------------------- On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112463/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 7:16 p.m.) > > > Review request for KDE Runtime and KDE Frameworks. > > > Description > ------- > > This is the initial port! I added two TODO lines in the diff for parts where > i'm not sure if I've ported them correctly. > Also, i needed a change in FindSamba.cmake to even get the samba detection > working. That reviewrequest is waiting here: > https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use > samba 3.x > > Once i know that this is actually working then i will comment some qDebug > lines. > > > Diffs > ----- > > kioslave/CMakeLists.txt ff66ab6 > kioslave/smb/CMakeLists.txt a3a2265 > kioslave/smb/kio_smb.h 55efb44 > kioslave/smb/kio_smb.cpp 2c2523a > kioslave/smb/kio_smb_auth.cpp 4d236b4 > kioslave/smb/kio_smb_browse.cpp fec6449 > kioslave/smb/kio_smb_config.cpp 81ce29c > kioslave/smb/kio_smb_dir.cpp 5573266 > kioslave/smb/kio_smb_file.cpp 827a519 > kioslave/smb/kio_smb_internal.h b895b81 > kioslave/smb/kio_smb_internal.cpp 3c35583 > kioslave/smb/kio_smb_mount.cpp a5a7e8e > > Diff: http://git.reviewboard.kde.org/r/112463/diff/ > > > Testing > ------- > > It compiles and gets loaded just fine. I tried testing this on an actual > samba share, but i kept getting a 111 error (connection refused) from kio_smb > so i'm hoping that is a local issue here. If someone else could try this out > and verify that it's either working or broken. > > > Thanks, > > Mark Gaiser > >
