----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/ -----------------------------------------------------------
Review request for kde-workspace, kwin, Fredrik Höglund, and Thomas Lübking. Bugs: 325837 http://bugs.kde.org/show_bug.cgi?id=325837 Repository: kde-workspace Description ------- Apparently in XCursorTheme::findAlternative() (file kcontrol/input/xcursor/xcursortheme.cpp) the alternatives for "size_bdiag" and "size_fdiag" are swapped, so for themes not containing "size_fdiag" the wrong resize cursor is shown in the preview. This patch fixes that long standing bug. (there has been no change to that function since 2007!) This also fixes the glitch mentioned in bug#325763, that the wrong arrows are used for the window resize hint after the theme change is applied (for the current X session). Diffs ----- kcontrol/input/xcursor/xcursortheme.cpp 010c9ad Diff: http://git.reviewboard.kde.org/r/113185/diff/ Testing ------- - Enter systemsettings->Workspace Appearance->Cursor Theme - Select a theme without "size_fdiag", f.e.: crystalwhite, DMZ, Adwaita, redglass - Look at the preview: without the patch, the wrong resize cursor is shown, with the patch it's the same as for Oxygen e.g. See atached screenshots File Attachments ---------------- KCM without the patch http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/9cb9ae8c-6614-49ea-aae2-fdbeb36dd71e__cursor.png KCM with the patch http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/f3cf8c6d-d2a0-4e96-8f77-75a53f66395f__cursor2.png Thanks, Wolfgang Bauer