> On May 20, 2013, 2:08 a.m., Ian Monroe wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > > > Frederik Gladhorn wrote: > Thanks for asking. On the (frameworks or kcd?) mailing list it was > mentioned that a much more complicated fix would be preferred. So I never > committed this since I don't have time to do the proper fix and it sounded > like this was not wanted.
Ok, i'm discarding the review request based on Frederik's comment. If this is not true, please k-f people comment. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/#review32794 ----------------------------------------------------------- On April 16, 2013, 1:26 p.m., Frederik Gladhorn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110042/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 1:26 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > Build fix for dbusmenu qt5 changes. > This appends the 5 to include path and lib dir in the find module. > Also rename the whole thing to not conflict with the Qt 4 version. > > > Diffs > ----- > > CMakeLists.txt 00402d4 > cmake/modules/FindDBusMenuQt.cmake 5af70ef > cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110042/diff/ > > > Testing > ------- > > > Thanks, > > Frederik Gladhorn > >
