----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/#review44857 -----------------------------------------------------------
kcontrol/krdb/krdb.cpp <http://git.reviewboard.kde.org/r/114219/#comment32060> QFile::encodeName() seems equal to QString::toLocal8Bit(), ::decodeName() to ::fromLocal8Bit() I don't think one can just drop one of them and whether transcoding is required probably depends on what is done to the string interim. If at all "KToolInvocation::klauncher()->setLaunchEnv()" would perform a second decode, so it probaly depends on what that does. Was "locale charmap" determined by the reporter in the bug? --- Secret world domination plan: ------------------------------ #1: classified #2: classified #3: force ASCII as global standard #4: classified #5: classified #6: classified #7: classified #8: classified #9: classified #a: classified - Thomas Lübking On Nov. 30, 2013, 12:26 a.m., Yichao Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114219/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2013, 12:26 a.m.) > > > Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo > Pereira Da Costa. > > > Bugs: 327919 > http://bugs.kde.org/show_bug.cgi?id=327919 > > > Repository: kde-workspace > > > Description > ------- > > list.join already returns a QString and there is no need to encode it and > cast back to QString again.... > > P.S. for a patch that applies to both KDE4 and KF5(master for kde-workspace, > frameworks for kdelibs?) How should I submit review request? Should I add > both in branch or submit two review request? (But often the patch cannot > apply directly due to context or file path changes). > > > Diffs > ----- > > kcontrol/krdb/krdb.cpp 92d84e9 > > Diff: http://git.reviewboard.kde.org/r/114219/diff/ > > > Testing > ------- > > Compiles. > Waiting for bug reporter's test. > > > Thanks, > > Yichao Yu > >