----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114214/#review45613 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Nov. 29, 2013, 9 p.m., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114214/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2013, 9 p.m.) > > > Review request for kdelibs and kdewin. > > > Repository: kdelibs > > > Description > ------- > > There is one global static for a QDesktopWidget in the code. We do not really > need that, given that QApplication returns a static instance already. > > This also fixes a bug I have in when closing yakuake: > > Application: Yakuake (yakuake), signal: EXCEPTION_ACCESS_VIOLATION > QtGuid4.dll!QScopedPointer<QObjectData,QScopedPointerDeleter<QObjectData> > >::data() [q:\qt-4.8.2\src\corelib\tools\qscopedpointer.h @ 135] at 0x54e6566a > QtGuid4.dll!qGetPtrHelper<QScopedPointer<QObjectData,QScopedPointerDeleter<QObjectData> > > >() [q:\qt-4.8.2\src\corelib\global\qglobal.h @ 2455] at 0x54e53d5b > QtGuid4.dll!QApplication::d_func() [q:\qt-4.8.2\src\gui\kernel\qapplication.h > @ 390] at 0x54e5e213 > QtGuid4.dll!QWidget::~QWidget() [q:\qt-4.8.2\src\gui\kernel\qwidget.cpp @ > 1634] at 0x54eeaa5b > QtGuid4.dll!QDesktopWidget::~QDesktopWidget() > [q:\qt-4.8.2\src\gui\kernel\qdesktopwidget_win.cpp @ 253] at 0x54f41002 > kdeui.dll!QDesktopWidget::`scalar deleting destructor'() [[unknown] @ -1] at > 0x5435921a > kdeui.dll!_k_s_deskWidget__LINE__::destroy() > [r:\build\kde\kdelibs-20110130\work\kdelibs-4.10.2\kdeui\windowmanagement\kwindowsystem_win.cpp > @ 60] at 0x543591bb > kdeui.dll!KCleanUpGlobalStatic::~KCleanUpGlobalStatic() > [r:\build\kde\kdelibs-20110130\work\kdelibs-4.10.2\kdecore\kernel\kglobal.h @ > 62] at 0x53f68498 > kdeui.dll!`_k_s_deskWidget__LINE__::operator->'::`13'::`dynamic atexit > destructor for 'cleanUpObject''() [[unknown] @ -1] at 0x543f76ad > kdeui.dll!_CRT_INIT() [f:\dd\vctools\crt_bld\self_x86\crt\src\crtdll.c @ 415] > at 0x54372424 > kdeui.dll!__DllMainCRTStartup() > [f:\dd\vctools\crt_bld\self_x86\crt\src\crtdll.c @ 526] at 0x54372630 > ... > > I don't think it breaks anything. > > > Diffs > ----- > > kdeui/windowmanagement/kwindowsystem_win.cpp e5b3a23 > > Diff: http://git.reviewboard.kde.org/r/114214/diff/ > > > Testing > ------- > > On Windows msvc2010 ;-) > > > Thanks, > > Patrick Spendrin > >
