----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46109 -----------------------------------------------------------
Much better, but... :) kio/bookmarks/kbookmarkdialog.h <https://git.reviewboard.kde.org/r/114479/#comment32896> @since isn't relevant for private methods, which are by definition private. kio/bookmarks/kbookmarkdialog.cc <https://git.reviewboard.kde.org/r/114479/#comment32895> this method could now call the other one with an empty selectGroup, to remove the code duplication, right? - David Faure On Dec. 24, 2013, 6:04 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114479/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2013, 6:04 a.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 152158 > http://bugs.kde.org/show_bug.cgi?id=152158 > > > Repository: kdelibs > > > Description > ------- > > When a user creates a new bookmark folder in the Add Bookmark dialog, make it > the current selected item. > > > Diffs > ----- > > kio/bookmarks/kbookmarkdialog.h a746c22 > kio/bookmarks/kbookmarkdialog.cc 713ceff > > Diff: https://git.reviewboard.kde.org/r/114479/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Add new folder w/o patch > > https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/1be1b4c9-eddd-43cf-b3fa-18cc0a44b212__before.png > Add new folder w/ patch > > https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/353b3c50-ccc8-4390-9d76-a9f85a703987__after.png > > > Thanks, > > Dawit Alemayehu > >