----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114623/#review46132 -----------------------------------------------------------
Ship it! what a silly function, but looks okay to me. - Martin Tobias Holmedahl Sandsmark On Dec. 22, 2013, 7:34 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114623/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2013, 7:34 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > kjs: Implement es6 Math.fround > > > Diffs > ----- > > kjs/math_object.h 3d193dd > kjs/math_object.cpp 89835e5 > > Diff: https://git.reviewboard.kde.org/r/114623/diff/ > > > Testing > ------- > > Basic Mozilla tests: > > Math.fround(0) // 0 > Math.fround(1) // 1 > Math.fround(1.337) // 1.3370000123977661 > Math.fround(1.5) // 1.5 > Math.fround(NaN) // NaN > Math.fround(Infinity) // Inf > Math.fround(-Infinity) // -Inf > > > Thanks, > > Bernd Buschinski > >