----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/ -----------------------------------------------------------
Review request for kde-workspace and David Stephen Hubner. Repository: kde-workspace Description ------- This patch reimplements the ReadPipe() function by using QProcess instead of popen(). This should make it more portable. As a positive side-effect, this also removes those "sh: lspci: command not found." messages when run in Konsole and lspci is not in the user's path. This was suggested on the kde-core-devel mailinglist in November: http://lists.kde.org/?l=kde-core-devel&m=138407113011843&w=2 http://lists.kde.org/?l=kde-core-devel&m=138409755820003&w=2 Diffs ----- kinfocenter/Modules/opengl/opengl.cpp 8901957 Diff: https://git.reviewboard.kde.org/r/114737/diff/ Testing ------- Ran KInfocenter with lspci in /usr/bin/ (i.e. in the user's path) and /sbin/ (not in the user's path). The OpenGL module showed the 3D accelerator info correctly in both cases. With lspci removed completely it showed "unknown" as expected. Thanks, Wolfgang Bauer
