----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115001/#review47338 -----------------------------------------------------------
given that the framework installs into KF5GlobalAccel and has the target KF5::GlobalAccel, I would drop the K. - Alexander Richardson On Jan. 13, 2014, 4:51 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115001/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2014, 4:51 p.m.) > > > Review request for kde-workspace and Martin Klapetek. > > > Repository: kde-workspace > > > Description > ------- > > add kf5 namespace to kglobalaccel dbus interface to prevent files and runtime > interfaces overlapping with kdelibs 4 > Goes with these reviews for kf5 and kde-runtime > https://git.reviewboard.kde.org/r/114999/ > https://git.reviewboard.kde.org/r/115000/ > > > Diffs > ----- > > kcontrol/keys/CMakeLists.txt 072e614 > kcontrol/keys/kglobalshortcutseditor.cpp ca11fcd > > Diff: https://git.reviewboard.kde.org/r/115001/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >